Drain channel on unsubscribe-all #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to use this library without potentially deadlocking.
|
This makes it easier to use this module without accidentally deadlocking. It's not perfect, but it's better than the current state of things. |
Stebalien
added a commit
to filecoin-project/lotus
that referenced
this pull request
May 10, 2022
When unsubscribing all topics, pubsub will drain the subscription channel to avoid deadlocks. See whyrusleeping/pubsub#1. fixes #7803
Stebalien
added a commit
to filecoin-project/lotus
that referenced
this pull request
May 10, 2022
When unsubscribing _all_ topics, pubsub will drain the subscription channel to avoid deadlocks. See whyrusleeping/pubsub#1. fixes #7803
5 tasks
arajasek
approved these changes
May 10, 2022
whyrusleeping
approved these changes
May 10, 2022
Well, the only other way to do this is to spawn a goroutine to unsubscribe while we continue to read from the channel. |
arajasek
pushed a commit
to filecoin-project/lotus
that referenced
this pull request
May 10, 2022
When unsubscribing _all_ topics, pubsub will drain the subscription channel to avoid deadlocks. See whyrusleeping/pubsub#1. fixes #7803
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And: